Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !825

administration: fix BT's "Check Python Code" with coding flag

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge jerome/erp5:fix/bt-pylint-encoding into master Jan 18, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

According to pep-0263, python scripts can define encoding magic on first or second line. If we use for example such a script:

  # coding: utf-8
  return "héhé"

then using .read() was wrong, because it return the script with headers, ie:

  ## Script (Python) "test_coding"
  ##bind container=container
  ##bind context=context
  ##bind namespace=
  ##bind script=script
  ##bind subpath=traverse_subpath
  ##parameters=
  ##title=
  ##
  # coding: utf-8
  return "héhé"

so the coding magic is no longer in first line and pylint complains with error like:

Cannot decode using encoding "ascii", unexpected byte at position 11 (invalid-encoded-data)]

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/bt-pylint-encoding
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7