Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !865

simulation: Test the divergence on Float Equivalence Tester with the epsilon-span by default

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Tatuya Kamada requested to merge tatuya/erp5:float_divergence into master May 14, 2019
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 2

Before: Float Equivalence Tester does not test the divergence even if Divergence Provider is ON

After: Float Equivalence Tester test the divergence with the epsilon-span if Divergence Provider is ON

Before, we needed the following condition to test the divergence at Float Equivalence Tester:

   "Divergence Provider is ON"  AND
   ("Absolute Tolerance has some value"  OR
    "Relative Tolerance has some value" )

However this default behavior was not consistent with other testers, and difficult to notice from the user interface. Thus test the divergence by default with the epsilon span which is defined in FloatEquivalenceTester class.

The epsilon-span is the same amount that when we put 0.0 into the ranges. The 0.0 has been the configuration of erp5_configurator_standard_trade_template.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: float_divergence
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7