Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !9

[RFC] ERP5Type.Base: .serialize() is possible without writing object to DB

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Kirill Smelkov requested to merge kirr/erp5:q/serialize-no-write into master Aug 02, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1000+

Hello,

I've noticed some project explicitly disable .serialize(), e.g. via passing serialize=False to BigFile._read_data() to avoid wasting disk space via not committing unchanged BTreeNode.

This can be avoided since ZODB provides explicit API to make sure object stays unchanged during commit, without marking it as changed - Connection.readCurrent(obj).

Thus this way if we fix .serialize() not to "change" object, we can drop workarounds to disable it everywhere. Also less space will be wasted in all places where .serialize() is used.

Not tested.

/cc @vpelletier, @jm, @seb

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: q/serialize-no-write
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7