Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !962

test_result: Support repositories or user ids with .

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/gitlab_connector_dot_in_project_id into master Oct 17, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

Because gitlab way of passing project ID as user/project URL-encoded does not support dots (it would needs to be encoded as %2E) and that requests rewrites %2F from URL to . (which is probably correct, that's the RFC), we cannot use encoded paths for when they contain a dot.

To workaround this, when user or repo as a dot, make another API call to get the numerical project ID and use that instead.

We only do that for projects with a dot because that's an extra request we'd like to avoid.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/gitlab_connector_dot_in_project_id
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7