Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !969

monaco_editor: allow inclusion of external js

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge jerome/erp5:feat/monaco_editor_external_js into master Oct 21, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

By using a magic comment such as

   // erp5_monaco_editor_include: ../other.js other

we can tell monaco editor that other.js will be loaded before the current javascript file, which helps the typescript compiler in diagnosing errors and providing completions.

rsvp, renderjs and jio are still always loaded because they are used in almost all our javscripts.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feat/monaco_editor_external_js
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7