Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G gitlab-ce
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • gitlab-ce
  • Merge requests
  • !3

NXD: Access token should be valid for project and namespace

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Alain Takoudjou requested to merge token_auth into 8-17-nxd Sep 20, 2018
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 3

when doing git clone https://gitlab-ci-token:RUNNER_TOKEN@GITLAB_URL/NAMESPACE/PROJECT.git user is always gitlab-ci-token and cannot be used to identify the project, runner token is not unique per project.

If two projects in the namespace has the same token and the wrong project is returned by build_access_token_check method, gitlab will simply return 404.

build_access_token_check now take namespace_id as parameter so that we can ensure that we authenticate on the right project.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: token_auth
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7