Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • jio jio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 18
    • Merge requests 18
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • nexedinexedi
  • jiojio
  • Merge requests
  • !21

JIODate: switching between local and UTC modes

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Douglas requested to merge Camata/jio:fix_jiodate_tests into master Apr 26, 2016
  • Overview 13
  • Commits 2
  • Changes 5

@romain and @klaus, please review this.

JIODate now has 2 methods to switch between local and UTC modes: localMode() and utcMode(). These were added because JIODate also exposes methods that can be affected my messing with the moment’s mode and the user can not be aware of this. They were used in the test failing because of timezone issues.

JIODate constructor also now takes into account a second parameter when parsing date-only strings (i.e., 2016-02-01) to create the moment object in local or UTC mode. This allows tests that use date-only strings to be timezone agnostic by using the UTC mode parsing.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_jiodate_tests
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7