Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • N neoppod
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • neoppod
  • Merge requests
  • !7

WIP: Do not send invalidations for new oids, just like ZEO

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Julien Muchembled requested to merge dont_invalidate_new into master Sep 15, 2017
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 6

It's only after I wrote this commit that I ran the whole test suite and then I realized that it breaks backup, because the backup master relies on invalidations to know which partition needs to be synced from upstream.

Even if this commit would reduce the impact of a memory leak, it does not avoid it completely, so it's just optimization. Is it worth, for example:

  • adding an RPC for the backup master to tell the upstream one that it's interested in invalidations for both modified and new oids ?
  • or rather stop using invalidations for that and send directly the list of partitions ?

The second option is actually an extra optimization.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dont_invalidate_new
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7