Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • R rdiff-backup
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • rdiff-backup
  • Merge requests
  • !8

pool: disable parallelism

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Jérome Perrin requested to merge jerome-nexedi-patch-51252 into nexedi Jun 26, 2020
  • Overview 12
  • Commits 1
  • Changes 1

This seem to have race conditions and not ready for production.

We observed some IndexError caused in

Traceback (most recent call last):
  File "python2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "python2.7/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "rdiff_backup/pool.py", line 47, in worker
    value = task.func(*task.args)
  File "rdiff_backup/restore.py", line 65, in get_diff
    diff = MirrorStruct.get_diff(mir_rorp, target_rorp)
  File "rdiff_backup/restore.py", line 292, in get_diff
    file_fp = cls.rf_cache.get_fp(expanded_index, mir_rorp)
  File "rdiff_backup/restore.py", line 392, in get_fp
    rf = longname.update_rf(self.get_rf(index, mir_rorp), mir_rorp,
  File "rdiff_backup/restore.py", line 388, in get_rf
    else: del self.rf_list[0]
IndexError: list assignment index out of range

apparently because the underlying code is not thread safe in the first place.

Edited Jun 26, 2020 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jerome-nexedi-patch-51252
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7