Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !14

Hotfix of invalid logger passed into tests into slapformat

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Tomáš Peterka requested to merge hotfix/test-logger into master Jun 02, 2017
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

I know the assertEqualCommands is a bit dangerous because computer.construct can issue extra malicious commands and we will not catch them with our tests ... but we shouldn't use logger for testing in the first place.

The whole slapformat needs thorough rewriting.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hotfix/test-logger
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7