Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !15

Revert "[test] Do not check non-function commands"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Tomáš Peterka requested to merge revert-889711ed into master Jun 05, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

This reverts commit 889711ed

This approach to solve checking of commands by logging is wrong. It can lead to malicious commands being executed so this test is no longer reliable.

We just should not test issued commands - test should use an isolated environment and then inspect the impact.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: revert-889711ed
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7