Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !296

slapformat: Fix python3 bytes/str mismatch in dump

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Xavier Thompson requested to merge xavier_thompson/slapos.core:fix_slapformat_python3 into master May 05, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

The slapos node format command fails in Python3 because it tries to dump information in str format into files opened in bytes mode. The unit tests didn't see this because they call the computer.format() method directly from Python without calling computer.dump() after like the command line does.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_slapformat_python3
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7