Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !296

Merged
Created May 05, 2021 by Xavier Thompson@xavier_thompsonOwner

slapformat: Fix python3 bytes/str mismatch in dump

  • Overview 2
  • Commits 1
  • Changes 2

The slapos node format command fails in Python3 because it tries to dump information in str format into files opened in bytes mode. The unit tests didn't see this because they call the computer.format() method directly from Python without calling computer.dump() after like the command line does.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_slapformat_python3
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7