Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !333

grid: fix "log buildout output in realtime"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/realtime-output-fix into master Sep 24, 2021
  • Overview 12
  • Commits 1
  • Pipelines 1
  • Changes 2

this fixes 86ce8b8e which had an error the current_output variable was not reset when the current output ended in \n.

As a result, logged output was sometimes containing some parts of the program output twice. We could even catch it in unit test, when running the test multiple times. It also happened on test node with https://erp5js.nexedi.net/#/test_result_module/20210826-1706D7F50/10

The is trivial, we reset the current output also in this case. The test suite is extended a bit, with added tests and test adjustments made during the debugging. With test_exec_large_output_multiline the problem triggers almost every time.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/realtime-output-fix
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7