Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !388

Clean up for the JSON API work

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rafael Monnerat requested to merge rafael/slapos.core:mixin-tool-cleanup-for-api into master Jun 01, 2022
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 20

The "internal" API only store dict, rather them store xml, this makes flexible to others APIs to be implemented w/o changing the core of the master.

It makes slapos.slap.slap only used on SlapTool context, releasing the internal API on having it, so it won't become a dependency anymore.

The approach is deprecate the usage of SlapTool as soon clients relies on a different API.

TODO:

  • Make Tests Pass
  • Clean up code (the creation of Compute Node and Compute Partition specially)
  • Cache the Compute Node XML in addition to the Dict (else the system will become too slow)
Edited Jun 29, 2022 by Rafael Monnerat
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mixin-tool-cleanup-for-api
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7