Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !438

Partial re-implementation of the Parameter editor

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rafael Monnerat requested to merge rafael/slapos.core:parameter-editor-refactor into master Oct 20, 2022
  • Overview 7
  • Commits 38
  • Pipelines 0
  • Changes 93

The re-implementation here is based on make 2 points:

  • Replace expandSchema to use ref-parser library
  • Replace tv4 by cfworker json schema (validator)

The selection of the validator to replace tv4, consider 2 criteria:

  • Don't use eval or anything that requires changes on CSP (like unsafe-eval)
  • Has the least amount of errors as possible (more important then speed)
  • Is ranked on well known on benchmark tests

See: https://github.com/ebdrup/json-schema-benchmark

This refactoring includes a large set of tests and fixes for parameter field (ie: required)

This MR replaces and extends https://lab.nexedi.com/nexedi/slapos.core/merge_requests/440

Edited Nov 01, 2022 by Rafael Monnerat
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: parameter-editor-refactor
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7