Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !575

utils: Fix untimeouted request in _ReadAsJson

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Xavier Thompson requested to merge xavier_thompson/slapos.core:fix/request_without_timeout into master Oct 02, 2023
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Add arbitrary timeout in requests.get() in _ReadAsJson, because that is called during requests (to fetch the JSON schema) and it can cause buildout to hang inside a slapos.cookbook:request if there is a network outage at that moment. This actually happened in ORS, we found this out with @jhuge by debugging it.

Edited Oct 09, 2023 by Xavier Thompson
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/request_without_timeout
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7