Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !791

Revert "slapgrid & SlapTool: Avoid POST if software release state is already as expected"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rafael Monnerat requested to merge rafael/slapos.core:rev-e28916c9 into master Jun 12, 2025
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

This reverts commit e28916c9 (in general).

The optimization introduced by that change is no longer necessary following commit b8d962a9 ("grid/slapgrid.py: reduce number of installation.available calls"). Since API calls are now less frequent, avoiding the POST to the master offers little benefit.

Worse, skipping the POST can now cause issues: if the software is reconstructed and its state transitions to "building", it may never be reported back as "available" in some race conditions, leading to incorrect or outdated local state.

Edited Jun 24, 2025 by Rafael Monnerat
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rev-e28916c9
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7