Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !813

slapgrid: Better detect when master is unavailable

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Xavier Thompson requested to merge xavier_thompson/slapos.core:fix/offline-instance-processing-master-unavailable into master Sep 29, 2025
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Improve master availability detection for online/offline instance processing: if instance list is successfully fetched from master, proceed, otherwise whatever the reason, fallback to just starting the services of existing instance.

Note that connection errors can occur in later steps as well, and that the instance list is susceptible to be cached if there are several runs within the same Python process.

Adapt tests, because /getFullComputerInformation is cached within the lifetime of a Python process, so the tests were not exactly mimicking consecutive runs.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/offline-instance-processing-master-unavailable
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7