Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.core
  • Merge requests
  • !823

check_software: fix false positive with software updated in place

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/shared_parts_using_soft_installed_cfg into master Oct 17, 2025
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 2

The check for shared part referencing software was not reporting a false positive in this scenario:

  1. install a software with shared parts referencing non shared part from software
  2. update software "in place", no longer using this broken shared part

because check software was checking all installed shared parts, regardless of whether they were used by the software being checked or not, the shared part from 1 was still reported as referencing software, which is incorrect as it is no longer used.

The fix consists in only checking shared parts that are referenced in .installed.cfg for the software being checked.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/shared_parts_using_soft_installed_cfg
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7