Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.rebootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slapos.rebootstrap
  • Merge requests
  • !1

Support python provided by a part that does not need install

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/already-installed-python into master Oct 09, 2019
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 3

With shared builds, it's now possible that the [python2.7] part that is providing executable for this buildout does not need to install any part and makes the interpreter available since recipe initialisation.

This is causing an error during the overriden method computing part signature, because parts are not installed yet:

An internal error occurred due to a bug in either zc.buildout or in a
recipe being used:
Traceback (most recent call last):
  File "zc/buildout/buildout.py", line 2242, in main
    getattr(buildout, command)(args)
  File "zc/buildout/buildout.py", line 638, in install
    self._install_parts(install_args)
  File "zc/buildout/buildout.py", line 704, in _install_parts
    self._compute_part_signatures(install_parts)
  File "slapos/rebootstrap/__init__.py", line 37, in wrapper
    return getattr(self, attr)(*args, **kw)
  File "slapos/rebootstrap/__init__.py", line 95, in _compute_part_signatures
    installed_part_options[part]['__buildout_signature__']
KeyError: 'already_installed_python'

To support that case, tolerate that parts are can be not installed yet at this point.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/already-installed-python
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7