Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.toolbox
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • slapos.toolbox
  • Merge requests
  • !140

check_slow_queries_digest_result: fix encoding on file opening

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Titouan Soulard requested to merge tsoulard/slapos.toolbox:fix-slowqueries-encoding into py2 Feb 06, 2025
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Sometimes, it seems the file analyzed can contain non-ASCII characters, giving errors such as:

codec can't decode byte 0xc3 in position 5138: ordinal not in range(128)

It seems there is no reason to not support UTF8. This change has been applied for a few weeks on Nexedi ERP5 production without problems.

/cc @tomo

Can we release a 0.128.2& if merging this? That way production will converge back to no fixup. I do not know if this applies to the Python 3 version not using backport LZMA, so we might also want to apply there.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-slowqueries-encoding
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7