Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S slapos.toolbox
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • slapos.toolbox
  • Merge requests
  • !93

test_check_service_state: fix a data race

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Xavier Thompson requested to merge xavier_thompson/slapos.toolbox:service_state_promise into master Feb 03, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

This slapos.toolbox test revealed a data race in test_check_service_state: when the supervisor process shuts down it cleans up some files that may simultaneously be destroyed by shutil.rmtree. This MR ensures shutil.rmtree is called after the supervisor has finished shutting down.

Edited Feb 04, 2021 by Xavier Thompson
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: service_state_promise
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7