Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1180

deploy-test: pre-install requests

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/StandaloneDeploymentScriptTest into master May 24, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

These tests are still using python setup.py test which installs missing packages to their latest versions. Recently, certifi (a requests dependency) published a new release with python3 only syntax, so running the test now got an error installing missing packages:

File "parts/slapos-package/playbook/roles/standalone-shared/.eggs/certifi-2022.5.18.1-py2.7.egg/certifi/core.py", line 17
    def where() -> str:
                ^
SyntaxError: invalid syntax

The playbook/roles/standalone-shared is defined on the test suite as instance parameters, so it seems we can not already install this package directly from playbook/roles/standalone-shared because test suite may define something different. For now, just install requests. All this will have to be addressed when we change this test to pre-install packages with slapos and use python -m unittest instead of python setup.py test.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/StandaloneDeploymentScriptTest
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7