Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !132

gitlab: use trusted proxies mechanism

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged iv requested to merge iv/slapos:trusted-proxies into master Jan 26, 2017
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 5

If not using trusted proxies, our frontend IPv6 are banned because rack attacks thinks the clients of the lab are the frontends, and banned them after a few mistakes on credentials, making the lab inaccessible for everyone.

Let's use X-Forwarding-For HTTP header set by the frontend to see the real client IPs. For this, it is necessary to add real_ip module to nginx.

Also, if this MR is accepted, I will need the IPv6 of the real lab frontends to set them as instance parameter nginx_real_ip_trusted_addresses.

More details on issue 9.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: trusted-proxies
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7