Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !1330

Closed
Created Jan 24, 2023 by Levin Zimmermann@levin.zimmermannMaintainer
  • Report abuse
Report abuse

software/helloworld: Switch to default go version

  • Overview 3
  • Commits 1
  • Changes 1

Hello @kirr,

as we discussed it here this patch changes the helloworld SR, so that it uses go1.18.

Tests were successful expect for one failure of seleniumserver which I believe to be unrelated, because it also happens from time to time with nexedi/master test results (please see 1, 2).


Full commit message:

Patch https://lab.nexedi.com/nexedi/slapos/commit/15e26abd explicitly declared go version 1.17 for the 'helloworld' SR.

This was done at a time when we already had [golang1.17] in component/golang, but the default was still go1.16. The explicit declaration allowed the 'helloworld' SR to already switch to the newest go version.

Since patch https://lab.nexedi.com/nexedi/slapos/commit/d32524c3d0fc7d1bbd6130a0d8f833c699b45107 we use go1.18 as our default version. In order to allow 'helloworld' to use our newest SlapOS supported go version, it's therefore sufficient nowadays to simply remove the explicit declaration.


Are there any objections? Thanks and

Best, Levin

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: helloworld-default-go
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7