stack/erp5: Fix master node separation in NEO URI (!1387) · Merge requests · nexedi / slapos

Levin Zimmermann requested to merge levin.zimmermann/slapos:fix-neo-master-node-separation-for-wcfs into master Apr 24, 2023

Hello Kirill,

in https://lab.nexedi.com/nexedi/slapos/commit/0cf70a6ef9423f9a09778b8e4f0f26438ae7e35f we already migrated the NEO URI concatenation to the recent format used by WCFS. Unfortunately we missed separating the address (IPv6 + port) of the master nodes from each other. Without adding the separator , between them, WCFS doesn't work with NEO clusters which have multiple master nodes, because NEO/go can't split the different master node addresses.

This is necessary for https://lab.nexedi.com/kirr/neo/merge_requests/2.

Due to the reasons mentioned in https://lab.nexedi.com/nexedi/slapos/merge_requests/1308 we can't add automatic tests for this fix now. I therefore created a dedicated instance just to test this fix manually. A bit overkill for such a small fix, but anyway I could verify now that this fix works. If needed I can provide access data for this instance in private.

Best, Levin

/cc @kirr

stack/erp5: Fix master node separation in NEO URI

Merge request reports