Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1501

software/rapid-cdn: make re6st-verification-url optional

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Titouan Soulard requested to merge tsoulard/slapos:for-mr-rabbit into master Jan 11, 2024
  • Overview 8
  • Commits 1
  • Pipelines 6
  • Changes 23

While working on deploying a frontend without Internet access, I noticed that a promise, re6st-connectivity.py, was failing every time. This promise tries to access to the URL http://[2001:67c:1254:4::1]/index.html and fails if it cannot. I am unsure of why this promise existed at the first place, but it seems that we might want to keep it to check for Internet connection on the frontend.

What this MR aims at doing is therefore to make the parameter optional: it will default to nothing, and the promise section will not be generated in instance.cfg when the parameter is unset, which by default will make the frontend work even without Internet access, or access to a filtered Internet, while also allowing to check for network connectivity if needed.

I am quite unsure if I did things right for this MR, so feel free to comment about anything. Tests are running, so we will see if it breaks anything.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: for-mr-rabbit
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7