Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1616

kvm/theia: Dont use allOf on resilient to extend properties

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rafael Monnerat requested to merge rafael/slapos:resilient-schema-allof-fixup into master Jul 26, 2024
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

allOf implies that all (both) schemas should be valid, but additionalProperties false wont allow it, since it become multually invalid. (You can validate only one or None)

Just use $ref to expand the list, it end up with the expected outcome reducing complexity.

Note: kvm wasn't using additionalProperties false but it was changed because it makes it future proof, in case we set it (we should set).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: resilient-schema-allof-fixup
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7