Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1639

Typing for CloudOoo tests.

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Carlos Ramos Carreño requested to merge vnmabus/slapos:feature/cloudooo_tests_typing into master Sep 06, 2024
  • Overview 8
  • Commits 2
  • Pipelines 0
  • Changes 3

Adds type hints for Cloudooo tests. Pyright passes in strict mode.

We made use of the function _get_fonts from PyPDF, which, although prefixed by an underscore, it is intended to be public (https://github.com/py-pdf/pypdf/issues/153).

Some of these changes were proposed as part of !1628 (merged) , but were postponed due to differences in opinion about typing, until a consensus is achieved.

Edited Oct 10, 2024 by Carlos Ramos Carreño
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/cloudooo_tests_typing
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7