Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1762

software/theia: do not use --all parameter in software run on import

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Klaus Wölfel requested to merge klaus/slapos:klaus/theia_remove_all_on_import into master Mar 12, 2025
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 2

Historically, the --all parameter was added to reprocess software releases which consist of locally modified git repositories and the only way to be sure to have the same software release on runner0 and runner1, if user had modified their local slapos.git repository on runner0, is to force the reprocessing of the software release on runner1.

Nowadays, a software release should not be updated in place, and the good practice is to clone a second time the repository containing the software.cfg if we need to deploy a second software release or a second version of the same software release. Or better: use URLs to deploy software releases. So forcing the build of the software release on runner1 doesn't make much sense anymore, in my opinion. Except if we develop a software release, but in this case what is built on runner1 is not important (only the new SR code is).

Reprocessing of all software releases is a risk because it depends on external services. And if these external services are not avialbale, reprocessing can lead to no resiliency at all.

Therefore we remove the --all paramater when running slapos node software.

Edited Mar 13, 2025 by Klaus Wölfel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: klaus/theia_remove_all_on_import
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7