Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !233

WIP: Fix softwaretype being case insensitive on options

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Jérome Perrin requested to merge fix/softwaretype_case_sensitive into master Oct 02, 2017
  • Overview 7
  • Commits 2
  • Pipelines 0
  • Changes 2

Because softwaretype recipe uses its own configparser directly to rewrite software type buildout before running buildout, it turns all options into lower case.

See https://lab.nexedi.com/nexedi/slapos/merge_requests/227#note_48387 for background, where I git hit by this problem trying to use an option name PATH.

According to python documention of the module, configparser turns all options to lowercase and expose optionxform method to make it case sensitive. This is what buildout use to do, but now buildout switched to its own implementation of configparser - with slightly different API, but the point is buildout options are case sensitive, so it's non intuitive to have case insensitive options in the instance buildout.

I added tests for this recipe at the same time, I could not find any.

/cc @rafael @vpelletier @alain.takoudjou @jm

[edit: some confusions case insensitive/sensitive]

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/softwaretype_case_sensitive
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7