Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !233

Closed
Created Oct 02, 2017 by Jérome Perrin@jeromeOwner
  • Report abuse
Report abuse

WIP: Fix softwaretype being case insensitive on options

  • Overview 7
  • Commits 2
  • Changes 2

Because softwaretype recipe uses its own configparser directly to rewrite software type buildout before running buildout, it turns all options into lower case.

See https://lab.nexedi.com/nexedi/slapos/merge_requests/227#note_48387 for background, where I git hit by this problem trying to use an option name PATH.

According to python documention of the module, configparser turns all options to lowercase and expose optionxform method to make it case sensitive. This is what buildout use to do, but now buildout switched to its own implementation of configparser - with slightly different API, but the point is buildout options are case sensitive, so it's non intuitive to have case insensitive options in the instance buildout.

I added tests for this recipe at the same time, I could not find any.

/cc @rafael @vpelletier @alain.takoudjou @jm

[edit: some confusions case insensitive/sensitive]

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/softwaretype_case_sensitive
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7