Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !423

slaprunner: use the new python version of runner-exporter

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Nicolas Wavrant requested to merge Nicolas/slapos:runner-exporter-python into master Oct 24, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 5

Currently for most of the import/export scripts of resiliency we still use bash scripts, which are directly rendered by slapos using jinja2 templates. This is an extremely bad practice, as it makes writing tests for these scripts infinitely impractical. Also, bash is a language that very few people can use properly. For exemple, I already saw this kind of things :

- grep ...

if [ $? -eq 0 ] 

(if you don't understand, that proves my point).

This combined to the current lack of tests make the resiliency stack untrustable.

This MR has the purpose to put the first stone on the road of cleaning this situation, by replacing the runner-exorpter script in bash by python, a scripting language mastered by everyone in Nexedi, and by stopping using scripts rendered as jinja templates.

This MR depends on https://lab.nexedi.com/nexedi/slapos.toolbox/merge_requests/44

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: runner-exporter-python
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7