Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !430

golang: Don't require users to put \ into gowork.install

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Kirill Smelkov requested to merge kirr/slapos:y/golang-install-trailshash into master Oct 29, 2018
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 3

Previously it was required to put \ into multi-entry gowork.install, because the way it was processed was to directly pass it into bash command, and if \n were there the command was cut by bash and the trailing was considered as another command.

We can avoid that by explicitly processing \n in gowork.install and translate it to just ' '. This helps people because now gowork.install becomes just a regular multiline buildout entry, similar e.g. to gowork.cpkgpath et all.

Here is one example where it helps:

https://lab.nexedi.com/jerome/slapos/commit/95c45fe0#note_68408

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: y/golang-install-trailshash
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7