Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !935

Merged
Created Mar 10, 2021 by Xavier Thompson@xavier_thompsonOwner

software/theia: Adjust to Caddy build changes

  • Overview 14
  • Commits 1
  • Changes 1

The changes to the caddy build method in https://lab.nexedi.com/nexedi/slapos/commit/1cfb657f05e3fd2d9e8b220c0945f8001104205f break software/theia because software/theia installs the go language server gopls (see https://lab.nexedi.com/nexedi/slapos/commit/5a7fffa540fe9ef9c30b2f373fe8ab78e49ce959) and at some point this required extending the previous caddy build method to make go installs both caddy and gopls (see https://lab.nexedi.com/nexedi/slapos/commit/f56c476a5fe5a9c1baa3547e76a623d5883be95d).

See this test result showing the problem

Fix software/theia by removing the now obsolete extension of the caddy build method and dropping gopls (which wasn't quite working anyway) in the same move.

EDIT: instead of dropping gopls, upgrade to gopls@v0.6.6 which can be installed using the standard go install method.

Edited Mar 15, 2021 by Xavier Thompson
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_theia_caddy_gopls
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7