Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • W wendelin.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • wendelin.core
  • Merge requests
  • !19

Allow explicitly overridding global ZBlk format for individual ZBigFile and ZBigArray

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Levin Zimmermann requested to merge levin.zimmermann/wendelin.core:set-zblk into master Oct 13, 2023
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 6

Hello Kirill,

the following patches allow setting the ZBlk format of individual ZBigFile and ZBigArray to a different value than the system-wide global value. This is useful in cases where we have an instance on which we do have some data which is better suited in a format different from most of the other data on this instance.

Regarding the implementation, it's a bit unfortunate that this patch needs to add "zblk_fmt" to ZBigFile's state and therefore making it less concise, but I wouldn't know how else we could make the user declared format persistent. I attempted to make this change backwards compatible e.g. to support ZBigFile states with two items or with three items in order to use an old DB with a newer version. I also added tests to ensure the changes are effective. Both make test.py and make test.go succeed on my instance.

Best, Levin

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: set-zblk
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7