Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • W wendelin.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedinexedi
  • wendelin.core
  • Merge requests
  • !25

Allow editable wheels.

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Carlos Ramos Carreño requested to merge vnmabus/wendelin.core:feature/editable_wheels into master Jun 06, 2024
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

When building an editable wheel it is not necessary that build_packages (or even run) is called before calling get_outputs (notice the following in https://setuptools.pypa.io/en/latest/userguide/extension.html#supporting-sdists-and-editable-installs-in-build-sub-commands : "Please note that custom sub-commands SHOULD NOT rely on run() being executed (or not) to provide correct return values for get_outputs(), get_output_mapping() or get_source_files(). The get_* methods should work independently of `run().").

Our implementation relied in the call to build_packages to set the name of the synthetic init file. This commit uses a property of the object instead, to compute that name whenever it is necessary. With this change, it is now possible to make editable wheels.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/editable_wheels
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7