Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • Z zodbtools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • nexedinexedi
  • zodbtools
  • Merge requests
  • !32

tests: Fix ztestdata-related tests on ZODB4

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Kirill Smelkov requested to merge kirr/zodbtools:y/zodb4 into master Oct 18, 2024
  • Overview 0
  • Commits 1
  • Changes 4

In bf772ce0 I introduced ztestdata fixture and we added several tests that use this fixture instead of only zext fixture. But contrary to zext I missed to corresponding xfail if underlying ZODB is ZODB4 and does not support access to raw extension bytes. As the result several tests started to fail with ZODB4, because on such ZODB extension is only dumped via heuristic and on best-effort basis and that cannot match original extension data bit to bit exactly:

https://lab.nexedi.com/nexedi/zodbtools/-/blob/36cba871/zodbtools/zodbdump.py#L93-102

One example failure is here:

https://erp5js.nexedi.net/#/test_result_module/20241017-58899E0D/2

-> Fix that by xfailing in both zext and ztestdata fixtures consistently.

Co-authored-by: Jérome Perrin jerome@nexedi.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: y/zodb4
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7